✨ Config option to use operating system certificates alongside rustls certificates
#620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neon-mmd
changed the title
rustls certificates
|
@evanyang1 It has been a week now. Any updates on this PR? 🙂 |
|
Nope. Do you have change requests? Or should it be approved? |
It is mostly approved from our side, just the tests seem to fail that's the only change I would suggest making and since you mention you have no idea on it I think I will suggest just run a clippy check by running the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides the new config option to allow the user to enable the use of operating system tls certificates when fetching the search results from the upstream search engines.
Why is this change important?
This change is essential as it allows the user more customizability of whether to use operating system certificates along side rustls certificates.
How to test these changes locally?
It can be tested by installing and running Websurfx as mentioned in the
docsand on thereadmeand by launching the browser and thoroughly testing. By enabling this new config option via the config file and testing if the app uses the operating system tls certificates or not.Closes #557